Split fwl/core class pt I.

Split fwl/core class pt I.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.

Committed: https://pdfium.googlesource.com/pdfium/+/dd17234c42e4572b85b6d74a07bc901974d061be

[dsinclair, 2016-11-17 19:08:38]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-17 19:08:39]

PTAL.

[npm, 2016-11-17 20:28:21]

lgtm

https://codereview.chromium.org/2506253004/diff/40001/xfa/fwl/core/cfwl_sysbtn.h
File xfa/fwl/core/cfwl_sysbtn.h (right):

https://codereview.chromium.org/2506253004/diff/40001/xfa/fwl/core/cfwl_sysbt...
xfa/fwl/core/cfwl_sysbtn.h:18: CFWL_SysBtn();
Can this have a destructor?

[Tom Sepez, 2016-11-18 17:33:04]

we might be able to get rid of all these little files by having nested classes,
which seems like what's actually going on here.  eg. IFWL_Widget::DataProvider
defined in ifwl_widget.h

[dsinclair, 2016-11-19 03:56:56]

https://codereview.chromium.org/2506253004/diff/40001/xfa/fwl/core/cfwl_sysbtn.h
File xfa/fwl/core/cfwl_sysbtn.h (right):

https://codereview.chromium.org/2506253004/diff/40001/xfa/fwl/core/cfwl_sysbt...
xfa/fwl/core/cfwl_sysbtn.h:18: CFWL_SysBtn();
On 2016/11/17 20:28:21, npm wrote:
> Can this have a destructor?

Done.

[dsinclair, 2016-11-19 03:57:12]

On 2016/11/18 17:33:04, Tom Sepez wrote:
> we might be able to get rid of all these little files by having nested
classes,
> which seems like what's actually going on here.  eg. IFWL_Widget::DataProvider
> defined in ifwl_widget.h

Done. PTAL.

[dsinclair, 2016-11-21 14:01:01]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 14:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 14:30:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:30:36]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-21 15:56:18]

Great! This looks better.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_barco...
File xfa/fwl/core/ifwl_barcode.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_barco...
xfa/fwl/core/ifwl_barcode.h:41: class IFWL_BarcodeDP : public
IFWL_Widget::DataProvider {
Can this go inside IFWL_Barcode?

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_check...
File xfa/fwl/core/ifwl_checkbox.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_check...
xfa/fwl/core/ifwl_checkbox.h:49: class IFWL_CheckBoxDP : public
IFWL_Widget::DataProvider {
Ditto with IFWL_Checkbox

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_datet...
File xfa/fwl/core/ifwl_datetimepicker.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.h:36: class IFWL_DateTimePickerDP : public
IFWL_Widget::DataProvider {
Ditto

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_form.h
File xfa/fwl/core/ifwl_form.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_form....
xfa/fwl/core/ifwl_form.h:49: class IFWL_FormDP : public
IFWL_Widget::DataProvider {
Ditto... but I imagine you tried already since I saw some inside.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:101: uint32_t GetStyles() const;
Why are we moving these back to the cpp file?
And ditto for the ones below.

[dsinclair, 2016-11-21 16:00:43]

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_barco...
File xfa/fwl/core/ifwl_barcode.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_barco...
xfa/fwl/core/ifwl_barcode.h:41: class IFWL_BarcodeDP : public
IFWL_Widget::DataProvider {
On 2016/11/21 15:56:18, npm wrote:
> Can this go inside IFWL_Barcode?

Followup.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_check...
File xfa/fwl/core/ifwl_checkbox.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_check...
xfa/fwl/core/ifwl_checkbox.h:49: class IFWL_CheckBoxDP : public
IFWL_Widget::DataProvider {
On 2016/11/21 15:56:18, npm wrote:
> Ditto with IFWL_Checkbox

Followup.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_datet...
File xfa/fwl/core/ifwl_datetimepicker.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_datet...
xfa/fwl/core/ifwl_datetimepicker.h:36: class IFWL_DateTimePickerDP : public
IFWL_Widget::DataProvider {
On 2016/11/21 15:56:18, npm wrote:
> Ditto

Followup.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_form.h
File xfa/fwl/core/ifwl_form.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_form....
xfa/fwl/core/ifwl_form.h:49: class IFWL_FormDP : public
IFWL_Widget::DataProvider {
On 2016/11/21 15:56:18, npm wrote:
> Ditto... but I imagine you tried already since I saw some inside.

Followup.

FormDP will actually go away, I'm just working through the series of CLs to get
there.

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2506253004/diff/80001/xfa/fwl/core/ifwl_widge...
xfa/fwl/core/ifwl_widget.h:101: uint32_t GetStyles() const;
On 2016/11/21 15:56:18, npm wrote:
> Why are we moving these back to the cpp file?
> And ditto for the ones below.

There is a circular dependency with CFWL_WidgetProperties that has to be
satisfied.

[dsinclair, 2016-11-21 16:52:06]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-21 16:53:08]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-11-21 16:53:08]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-21 16:53:09]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2506253004/#ps120001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-11-21 16:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:04:06]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1479747188960370,
"parent_rev": "b4455b90b1c86ab94986e4f470c963f1e91b27ba", "commit_rev":
"dd17234c42e4572b85b6d74a07bc901974d061be"}

[commit-bot: I haz the power, 2016-11-21 17:04:08]

Description was changed from

==========
Split fwl/core class pt I.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.
==========

to

==========
Split fwl/core class pt I.

Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.

Committed:
https://pdfium.googlesource.com/pdfium/+/dd17234c42e4572b85b6d74a07bc901974d0...
==========

[commit-bot: I haz the power, 2016-11-21 17:04:09]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/dd17234c42e4572b85b6d74a07bc901974d0...