Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2506253003: Fix insufficient escaping of <webview> (Closed)

Created:
4 years, 1 month ago by avallee
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix insufficient escaping of <webview> <webview> needs to be &amp;lt;webview> such that the xml parses it as &lt;webview> which will be concatenated into the about:flags html source. BUG=665722 Committed: https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436 Cr-Commit-Position: refs/heads/master@{#432939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
avallee
Typo fix.
4 years, 1 month ago (2016-11-17 15:42:53 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-11-17 18:44:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506253003/1
4 years, 1 month ago (2016-11-17 19:03:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 20:10:54 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:29:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89c538f4b15cb612c90605910bf2005142e46436
Cr-Commit-Position: refs/heads/master@{#432939}

Powered by Google App Engine
This is Rietveld 408576698