Issue 25062005: Add ability to determine if a capture sink is a renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25062005: Add ability to determine if a capture sink is a renderer.

Created:
7 years, 2 months ago by ajm

Modified:
7 years, 2 months ago

Reviewers:
jiayl

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add ability to determine if a capture sink is a renderer. Don't call CaptureData on renderers when the track is disabled.

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -6 lines)			Patch
M	content/renderer/media/webrtc_audio_capturer_sink_owner.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_audio_device_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_audio_device_impl.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_local_audio_renderer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_local_audio_renderer.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_local_audio_track.cc	View	2 chunks	+12 lines, -6 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

ajm

7 years, 2 months ago (2013-09-28 01:52:22 UTC) #1

https://codereview.chromium.org/25062005/diff/1/content/renderer/media/webrtc...
File content/renderer/media/webrtc_local_audio_track.cc (right):

https://codereview.chromium.org/25062005/diff/1/content/renderer/media/webrtc...
content/renderer/media/webrtc_local_audio_track.cc:184: last =
std::remove_if(first, last,
Not sure if this will do the right thing; I haven't tested it.

Expand Messages | Collapse Messages