Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 25062002: Rebaselining xfermodeimagefilter (Closed)

Created:
7 years, 2 months ago by sugoi1
Modified:
7 years, 2 months ago
Reviewers:
epoger, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Rebaselining xfermodeimagefilter Adding new baselines and removing the line in ignore-tests.txt BUG= R=bsalomon@google.com, epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -162 lines) Patch
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json View 3 chunks +11 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json View 3 chunks +11 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Debug/expected-results.json View 3 chunks +10 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-IntelRhb-SGX544-x86-Release/expected-results.json View 3 chunks +10 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-NoGPU-x86_64-Debug/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 5 chunks +5 lines, -5 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 4 chunks +4 lines, -4 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sugoi1
7 years, 2 months ago (2013-09-27 14:47:55 UTC) #1
bsalomon
On 2013/09/27 14:47:55, sugoi1 wrote: lgtm. It's fine to commit these without waiting for an ...
7 years, 2 months ago (2013-09-27 14:50:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/25062002/1
7 years, 2 months ago (2013-09-27 14:56:21 UTC) #3
epoger
On 2013/09/27 14:50:39, bsalomon wrote: > On 2013/09/27 14:47:55, sugoi1 wrote: > > lgtm. It's ...
7 years, 2 months ago (2013-09-27 14:59:15 UTC) #4
sugoi1
Committed patchset #1 manually as r11499 (presubmit successful).
7 years, 2 months ago (2013-09-27 15:00:49 UTC) #5
sugoi1
7 years, 2 months ago (2013-09-27 15:02:43 UTC) #6
Message was sent while issue was closed.
On 2013/09/27 14:59:15, epoger wrote:
> On 2013/09/27 14:50:39, bsalomon wrote:
> > On 2013/09/27 14:47:55, sugoi1 wrote:
> > 
> > lgtm. It's fine to commit these without waiting for an lgtm as there is no
> real
> > way for anyone to verify from the diff.
> 
> Well, the commit-bot certainly requires an LGTM from a Big Powerful Person
such
> as yourself. :-)
> 
> At any rate, I did manually examine all of the diffs and confirmed that only
> xfermodeimagefilter tests were modified.
> 
> As Brian notes, we do not have a good way for a reviewer to view the pixel
> diffs.  So we are at the mercy of the CL creator to do so.  Alexis, were you
> able to use svndiff.py (or some other method) to review the pixel diffs, and
> make sure they seemed reasonable?

Yes I did, svndiff.py worked fine.

Powered by Google App Engine
This is Rietveld 408576698