Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f315311a35500819d4a2ecaf3db6f98d3c0393cd..4038069fc83d3de22b59a1684e64cff120dd90de 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -6740,6 +6740,24 @@ void RenderFrameImpl::OnSetPepperVolume(int32_t pp_instance, double volume) {
}
#endif // ENABLE_PLUGINS
+void RenderFrameImpl::ShowCreatedWindow(bool opened_by_user_gesture,
+ RenderWidget* render_widget_to_show,
+ WebNavigationPolicy policy,
+ const gfx::Rect& initial_rect) {
+ // |render_widget_to_show| is the main RenderWidget for a pending window
+ // created by this object, but not yet shown. The tab is currently offscreen,
+ // and still owned by the opener. Sending |FrameHostMsg_ShowCreatedWindow|
+ // will move it off the opener's pending list, and put it in its own tab or
+ // window.
+ //
+ // This call happens only for renderer-created windows; for example, when a
+ // tab is created by script via window.open().
+ Send(new FrameHostMsg_ShowCreatedWindow(
+ GetRoutingID(), render_widget_to_show->routing_id(),
+ RenderViewImpl::NavigationPolicyToDisposition(policy), initial_rect,
+ opened_by_user_gesture));
+}
+
void RenderFrameImpl::RenderWidgetSetFocus(bool enable) {
#if BUILDFLAG(ENABLE_PLUGINS)
// Notify all Pepper plugins.
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698