Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: content/common/render_message_filter.mojom

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/swapped_out_messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/render_message_filter.mojom
diff --git a/content/common/render_message_filter.mojom b/content/common/render_message_filter.mojom
index df4cd7e6b93be7ec12a6d2403dcd35b774395d14..78c93efe1f55c49bcbaf4cad4961e013a10d87f2 100644
--- a/content/common/render_message_filter.mojom
+++ b/content/common/render_message_filter.mojom
@@ -13,8 +13,8 @@ import "ui/base/mojo/window_open_disposition.mojom";
import "url/mojo/url.mojom";
struct CreateNewWindowParams {
- // Routing ID of the view initiating the open.
- int32 opener_id;
+ // The routing id of the frame initiating the open.
+ int32 opener_render_frame_id;
// True if this open request came in the context of a user gesture.
bool user_gesture;
@@ -29,9 +29,6 @@ struct CreateNewWindowParams {
// has been specified). UTF8 encoded string.
string frame_name;
- // The routing id of the frame initiating the open.
- int32 opener_render_frame_id;
-
// The URL of the frame initiating the open.
url.mojom.Url opener_url;
@@ -49,7 +46,7 @@ struct CreateNewWindowParams {
ui.mojom.WindowOpenDisposition disposition;
// The URL that will be loaded in the new window (empty if none has been
- // sepcified).
+ // specified).
url.mojom.Url target_url;
// The referrer that will be used to load |target_url| (empty if none has
@@ -62,7 +59,10 @@ struct CreateNewWindowParams {
struct CreateNewWindowReply {
// The ID of the view to be created. If the ID is MSG_ROUTING_NONE, then the
- // view couldn't be created.
+ // opener RenderFrame should not create a RenderView in its process.
+ // MSG_ROUTING_NONE does not necessarily indicate failure; it may also occur
+ // in cases where a window was created, but the opener relationship is
+ // severed.
int32 route_id;
// The ID of the main frame hosted in the view.
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/swapped_out_messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698