Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/DEPS ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 7a1dfea736226d00116a062f1d3e349b1414c1c5..6901145aaa6833ef81c211be102a19273689717c 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -215,24 +215,13 @@ void RenderMessageFilter::CreateNewWindow(
mojom::CreateNewWindowParamsPtr params,
const CreateNewWindowCallback& callback) {
bool no_javascript_access;
- bool can_create_window =
- GetContentClient()->browser()->CanCreateWindow(
- params->opener_url,
- params->opener_top_level_frame_url,
- params->opener_security_origin,
- params->window_container_type,
- params->target_url,
- params->referrer,
- params->frame_name,
- params->disposition,
- params->features,
- params->user_gesture,
- params->opener_suppressed,
- resource_context_,
- render_process_id_,
- params->opener_id,
- params->opener_render_frame_id,
- &no_javascript_access);
+ bool can_create_window = GetContentClient()->browser()->CanCreateWindow(
+ render_process_id_, params->opener_render_frame_id, params->opener_url,
+ params->opener_top_level_frame_url, params->opener_security_origin,
+ params->window_container_type, params->target_url, params->referrer,
+ params->frame_name, params->disposition, params->features,
+ params->user_gesture, params->opener_suppressed, resource_context_,
+ &no_javascript_access);
mojom::CreateNewWindowReplyPtr reply = mojom::CreateNewWindowReply::New();
if (!can_create_window) {
@@ -250,7 +239,7 @@ void RenderMessageFilter::CreateNewWindow(
reply->cloned_session_storage_namespace_id = cloned_namespace->id();
render_widget_helper_->CreateNewWindow(
- std::move(params), no_javascript_access, PeerHandle(), &reply->route_id,
+ std::move(params), no_javascript_access, &reply->route_id,
&reply->main_frame_route_id, &reply->main_frame_widget_route_id,
cloned_namespace.get());
callback.Run(std::move(reply));
« no previous file with comments | « content/browser/renderer_host/DEPS ('k') | content/browser/renderer_host/render_view_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698