Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index b5a10565cf4a67b0d50a860b0b9d8afa2462a980..7a9c62a1b0c99f04c8ad1b2ad5182bfbd06c2f9f 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -387,6 +387,8 @@ void AwContentBrowserClient::SelectClientCertificate(
}
bool AwContentBrowserClient::CanCreateWindow(
+ int opener_render_process_id,
+ int opener_render_frame_id,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -399,9 +401,6 @@ bool AwContentBrowserClient::CanCreateWindow(
bool user_gesture,
bool opener_suppressed,
content::ResourceContext* context,
- int render_process_id,
- int opener_render_view_id,
- int opener_render_frame_id,
bool* no_javascript_access) {
// We unconditionally allow popup windows at this stage and will give
// the embedder the opporunity to handle displaying of the popup in
« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/android/webapps/single_tab_mode_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698