Make window.open() IPCs be frame-based

content/browser/renderer_host/render_view_host_delegate.h

Index: content/browser/renderer_host/render_view_host_delegate.h
diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h
index a5d1d095265d27bf224d3da24ba49034082fd2ed..207afc94a2756b46d1af1187de8cd384abff2322 100644
--- a/content/browser/renderer_host/render_view_host_delegate.h
+++ b/content/browser/renderer_host/render_view_host_delegate.h
@@ -16,7 +16,6 @@
 #include "content/common/content_export.h"
 #include "net/base/load_states.h"
 #include "third_party/WebKit/public/web/WebPopupType.h"
-#include "ui/base/window_open_disposition.h"
 
 class GURL;
 
@@ -41,10 +40,6 @@ class SiteInstance;
 class WebContents;
 struct RendererPreferences;
 
-namespace mojom {
-class CreateNewWindowParams;
-}
-
 //
 // RenderViewHostDelegate
 //
@@ -131,31 +126,6 @@ class CONTENT_EXPORT RenderViewHostDelegate {
   // The contents' preferred size changed.
   virtual void UpdatePreferredSize(const gfx::Size& pref_size) {}
 
-  // The page is trying to open a new page (e.g. a popup window). The window
-  // should be created associated with the given |route_id| in the process of
-  // |source_site_instance|, but it should not be shown yet. That
-  // should happen in response to ShowCreatedWindow.
-  // |params.window_container_type| describes the type of RenderViewHost
-  // container that is requested -- in particular, the window.open call may
-  // have specified 'background' and 'persistent' in the feature string.
-  //
-  // The passed |params.frame_name| parameter is the name parameter that was
-  // passed to window.open(), and will be empty if none was passed.
-  //
-  // Note: this is not called "CreateWindow" because that will clash with
-  // the Windows function which is actually a #define.
-  //
-  // TODO(alexmos): This should be moved to RenderFrameHostDelegate, and the
-  // corresponding IPC message should be sent by the RenderFrame creating the
-  // new window.
-  virtual void CreateNewWindow(
-      SiteInstance* source_site_instance,
-      int32_t route_id,
-      int32_t main_frame_route_id,
-      int32_t main_frame_widget_route_id,
-      const mojom::CreateNewWindowParams& params,
-      SessionStorageNamespace* session_storage_namespace) {}
-
   // The page is trying to open a new widget (e.g. a select popup). The
   // widget should be created associated with the given |route_id| in the
   // process |render_process_id|, but it should not be shown yet. That should
@@ -170,17 +140,6 @@ class CONTENT_EXPORT RenderViewHostDelegate {
   virtual void CreateNewFullscreenWidget(int32_t render_process_id,
                                          int32_t route_id) {}
 
-  // Show a previously created page with the specified disposition and bounds.
-  // The window is identified by the route_id passed to CreateNewWindow.
-  //
-  // Note: this is not called "ShowWindow" because that will clash with
-  // the Windows function which is actually a #define.
-  virtual void ShowCreatedWindow(int process_id,
-                                 int route_id,
-                                 WindowOpenDisposition disposition,
-                                 const gfx::Rect& initial_rect,
-                                 bool user_gesture) {}
-
   // Show the newly created widget with the specified bounds.
   // The widget is identified by the route_id passed to CreateNewWidget.
   virtual void ShowCreatedWidget(int process_id,