Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Few more fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/security_exploit_browsertest.cc
diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc
index 69e69444f3f905ffb74c3b47841311c70cceb47e..65e8540980716e7ecba81d4189b5264733aec369 100644
--- a/content/browser/security_exploit_browsertest.cc
+++ b/content/browser/security_exploit_browsertest.cc
@@ -273,10 +273,11 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,
// TODO(avi): This should be made unique from the view routing ID once
// RenderViewHostImpl has-a RenderWidgetHostImpl. https://crbug.com/545684
int32_t main_frame_widget_routing_id = duplicate_routing_id;
- pending_rvh->CreateNewWindow(duplicate_routing_id, main_frame_routing_id,
- main_frame_widget_routing_id,
- mojom::CreateNewWindowParams(),
- session_storage.get());
+ static_cast<RenderFrameHostImpl*>(pending_rvh->GetMainFrame())
+ ->OnCreateNewWindow(duplicate_routing_id, main_frame_routing_id,
+ main_frame_widget_routing_id,
+ mojom::CreateNewWindowParams(),
+ session_storage.get());
// If the above operation doesn't cause a crash, the test has succeeded!
}

Powered by Google App Engine
This is Rietveld 408576698