Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2173)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Few more fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index 105881226da37db55962d1f95d80ba444cac0582..fd80c3923eaee8455afb809bfb70c1c7038b7cd3 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -32,18 +32,12 @@
#include "third_party/WebKit/public/web/WebConsoleMessage.h"
#include "third_party/WebKit/public/web/WebPopupType.h"
#include "third_party/skia/include/core/SkColor.h"
-#include "ui/base/window_open_disposition.h"
namespace content {
class PageState;
-class SessionStorageNamespace;
struct FrameReplicationState;
-namespace mojom {
-class CreateNewWindowParams;
-}
-
// This implements the RenderViewHost interface that is exposed to
// embedders of content, and adds things only visible to content.
//
@@ -186,13 +180,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
sudden_termination_allowed_ = enabled;
}
- // Creates a new RenderView with the given route id.
- void CreateNewWindow(int32_t route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- const mojom::CreateNewWindowParams& params,
- SessionStorageNamespace* session_storage_namespace);
-
// Creates a new RenderWidget with the given route id. |popup_type| indicates
// if this widget is a popup and what kind of popup it is (select, autofill).
void CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type);

Powered by Google App Engine
This is Rietveld 408576698