Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: content/browser/frame_host/interstitial_page_impl.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Few more fixes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/interstitial_page_impl.h
diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h
index 7e5dbe160b2302be7220019f043937f282684e0a..a9c6dd22043daf41dd095151214d3f0c6b080354 100644
--- a/content/browser/frame_host/interstitial_page_impl.h
+++ b/content/browser/frame_host/interstitial_page_impl.h
@@ -114,6 +114,18 @@ class CONTENT_EXPORT InterstitialPageImpl
void Copy() override;
void Paste() override;
void SelectAll() override;
+ void CreateNewWindow(
+ SiteInstance* source_site_instance,
+ int32_t render_view_route_id,
+ int32_t main_frame_route_id,
+ int32_t main_frame_widget_route_id,
+ const mojom::CreateNewWindowParams& params,
+ SessionStorageNamespace* session_storage_namespace) override;
+ void ShowCreatedWindow(int process_id,
+ int main_frame_widget_route_id,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_rect,
+ bool user_gesture) override;
// RenderViewHostDelegate implementation:
RenderViewHostDelegateView* GetDelegateView() override;
@@ -125,23 +137,11 @@ class CONTENT_EXPORT InterstitialPageImpl
int error_code) override;
RendererPreferences GetRendererPrefs(
BrowserContext* browser_context) const override;
- void CreateNewWindow(
- SiteInstance* source_site_instance,
- int32_t route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- const mojom::CreateNewWindowParams& params,
- SessionStorageNamespace* session_storage_namespace) override;
void CreateNewWidget(int32_t render_process_id,
int32_t route_id,
blink::WebPopupType popup_type) override;
void CreateNewFullscreenWidget(int32_t render_process_id,
int32_t route_id) override;
- void ShowCreatedWindow(int process_id,
- int route_id,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_rect,
- bool user_gesture) override;
void ShowCreatedWidget(int process_id,
int route_id,
const gfx::Rect& initial_rect) override;

Powered by Google App Engine
This is Rietveld 408576698