content/renderer/render_widget.cc - Issue 2506183002: Make window.open() IPCs be frame-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)

Patch Set: Compile fix. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget.cc

diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc

index 637ad27559b658c23c9a6c38d8edf55d9d4391b8..5e3e5d603553dac65d953ac040d0d95e197fbdaf 100644

--- a/content/renderer/render_widget.cc

+++ b/content/renderer/render_widget.cc

@@ -1371,6 +1371,7 @@ void RenderWidget::show(WebNavigationPolicy policy) {

// The opener is responsible for actually showing this widget.

show_callback_.Run(this, policy, initial_rect_);

+ show_callback_.Reset();

// NOTE: initial_rect_ may still have its default values at this point, but

// that's okay. It'll be ignored if as_popup is false, or the browser