Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Compile fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.h
diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h
index 67575e368863882279e76fe17b0e95dadb7f115c..059d10194b9cea76833fc2f2af6922d906a01a11 100644
--- a/chrome/browser/chrome_content_browser_client.h
+++ b/chrome/browser/chrome_content_browser_client.h
@@ -191,7 +191,9 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
content::MediaObserver* GetMediaObserver() override;
content::PlatformNotificationService* GetPlatformNotificationService()
override;
- bool CanCreateWindow(const GURL& opener_url,
+ bool CanCreateWindow(int opener_render_process_id,
+ int opener_render_frame_id,
+ const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
WindowContainerType container_type,
@@ -203,9 +205,6 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {
bool user_gesture,
bool opener_suppressed,
content::ResourceContext* context,
- int render_process_id,
- int opener_render_view_id,
- int opener_render_frame_id,
bool* no_javascript_access) override;
void ResourceDispatcherHostCreated() override;
content::SpeechRecognitionManagerDelegate*

Powered by Google App Engine
This is Rietveld 408576698