Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Compile fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index a6bb56546a7109084126a3105ee4849681f6040c..9e9bdcab6ef317e266f64e2ad37727b12b1802da 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -388,6 +388,8 @@ void AwContentBrowserClient::SelectClientCertificate(
}
bool AwContentBrowserClient::CanCreateWindow(
+ int opener_render_process_id,
+ int opener_render_frame_id,
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
const GURL& source_origin,
@@ -400,9 +402,6 @@ bool AwContentBrowserClient::CanCreateWindow(
bool user_gesture,
bool opener_suppressed,
content::ResourceContext* context,
- int render_process_id,
- int opener_render_view_id,
- int opener_render_frame_id,
bool* no_javascript_access) {
// We unconditionally allow popup windows at this stage and will give
// the embedder the opporunity to handle displaying of the popup in

Powered by Google App Engine
This is Rietveld 408576698