Make window.open() IPCs be frame-based

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 6638 matching lines @@
 }
 
 void RenderFrameImpl::OnSetPepperVolume(int32_t pp_instance, double volume) {
   PepperPluginInstanceImpl* instance = static_cast<PepperPluginInstanceImpl*>(
       PepperPluginInstance::Get(pp_instance));
   if (instance)
     instance->audio_controller().SetVolume(volume);
 }
 #endif  // ENABLE_PLUGINS
 
+void RenderFrameImpl::ShowCreatedWindow(bool opened_by_user_gesture,
+                                        RenderWidget* render_widget_to_show,
+                                        WebNavigationPolicy policy,
+                                        const gfx::Rect& initial_rect) {
+  // |render_widget_to_show| is the main RenderWidget for a pending window
+  // created by this object, but not yet shown. The tab is currently offscreen,
+  // and still owned by the opener. Sending |FrameHostMsg_ShowCreatedWindow|
+  // will move it off the opener's pending list, and put it in its own tab or
+  // window.
+  //
+  // This call happens only for renderer-created windows; for example, when a
+  // tab is created by script via window.open().
+  Send(new FrameHostMsg_ShowCreatedWindow(
+      GetRoutingID(), render_widget_to_show->routing_id(),
+      RenderViewImpl::NavigationPolicyToDisposition(policy), initial_rect,

[alexmos, 2016/12/13 18:41:41]

Would it make sense to also move NavigationPolicyToDisposition to
RenderFrameImpl?  (No need to do it in this CL.)  I guess there's still one use
left in RV vs. two in RF.

[ncarter (slow), 2016/12/15 00:33:17]

I actually looked into this before you even mentioned it (we are very much on
the same page!)

TL;DR is that, so long as there are still callers in RenderViewImpl, that's a
better place for it. The existing friend declarations only allow calling private
members in one direction.

[alexmos, 2016/12/15 18:36:48]

Acknowledged.

+      opened_by_user_gesture));
+}
+
 void RenderFrameImpl::RenderWidgetSetFocus(bool enable) {
 #if BUILDFLAG(ENABLE_PLUGINS)
   // Notify all Pepper plugins.
   for (auto* plugin : active_pepper_instances_)
     plugin->SetContentAreaFocus(enable);
 #endif
 }
 
 void RenderFrameImpl::RenderWidgetWillHandleMouseEvent() {
 #if BUILDFLAG(ENABLE_PLUGINS)
   // This method is called for every mouse event that the RenderWidget receives.
   // And then the mouse event is forwarded to blink, which dispatches it to the
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content