Make window.open() IPCs be frame-based

content/browser/renderer_host/render_view_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 14 matching lines @@
 #include "content/browser/site_instance_impl.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/render_process_host_observer.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/window_container_type.h"
 #include "net/base/load_states.h"
 #include "third_party/WebKit/public/web/WebAXEnums.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 #include "third_party/WebKit/public/web/WebPopupType.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/window_open_disposition.h"

[alexmos, 2016/12/13 18:41:40]

remove?

[ncarter (slow), 2016/12/15 00:33:16]

Done.

 
 namespace content {
 
 class PageState;
-class SessionStorageNamespace;
 struct FrameReplicationState;
 
-namespace mojom {
-class CreateNewWindowParams;
-}
-
 // This implements the RenderViewHost interface that is exposed to
 // embedders of content, and adds things only visible to content.
 //
 // The exact API of this object needs to be more thoroughly designed. Right
 // now it mimics what WebContentsImpl exposed, which is a fairly large API and
 // may contain things that are not relevant to a common subset of views. See
 // also the comment in render_view_host_delegate.h about the size and scope of
 // the delegate API.
 //
 // Right now, the concept of page navigation (both top level and frame) exists
@@ skipping 122 matching lines @@
   void ClosePageIgnoringUnloadEvents();
 
   // Tells the renderer view to focus the first (last if reverse is true) node.
   void SetInitialFocus(bool reverse);
 
   bool SuddenTerminationAllowed() const;
   void set_sudden_termination_allowed(bool enabled) {
     sudden_termination_allowed_ = enabled;
   }
 
-  // Creates a new RenderView with the given route id.
-  void CreateNewWindow(int32_t route_id,
-                       int32_t main_frame_route_id,
-                       int32_t main_frame_widget_route_id,
-                       const mojom::CreateNewWindowParams& params,
-                       SessionStorageNamespace* session_storage_namespace);
-
   // Creates a new RenderWidget with the given route id.  |popup_type| indicates
   // if this widget is a popup and what kind of popup it is (select, autofill).
   void CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type);
 
   // Creates a full screen RenderWidget.
   void CreateNewFullscreenWidget(int32_t route_id);
 
   // Send RenderViewReady to observers once the process is launched, but not
   // re-entrantly.
   void PostRenderViewReady();
@@ skipping 141 matching lines @@
   bool render_view_ready_on_process_launch_;
 
   base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_