Make window.open() IPCs be frame-based

content/browser/renderer_host/render_view_host_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/process/kill.h"
 #include "base/strings/string16.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/common/content_export.h"
 #include "net/base/load_states.h"
 #include "third_party/WebKit/public/web/WebPopupType.h"
 #include "ui/base/window_open_disposition.h"

[alexmos, 2016/12/13 18:41:40]

Can you now remove this too?

[ncarter (slow), 2016/12/15 00:33:16]

Done.

 
 class GURL;
 
 namespace IPC {
 class Message;
 }
 
 namespace gfx {
 class Rect;
 class Size;
 }
 
 namespace content {
 
 class BrowserContext;
 class FrameTree;
 class PageState;
 class RenderViewHost;
 class RenderViewHostDelegateView;
 class SessionStorageNamespace;
 class SiteInstance;
 class WebContents;
 struct RendererPreferences;
 
-namespace mojom {
-class CreateNewWindowParams;
-}
-
 //
 // RenderViewHostDelegate
 //
 //  An interface implemented by an object interested in knowing about the state
 //  of the RenderViewHost.
 //
 //  This interface currently encompasses every type of message that was
 //  previously being sent by WebContents itself. Some of these notifications
 //  may not be relevant to all users of RenderViewHost and we should consider
 //  exposing a more generic Send function on RenderViewHost and a response
@@ skipping 66 matching lines @@
   // refocus on the modal dialog, flash title etc).
   virtual void OnIgnoredUIEvent() {}
 
   // The page wants the hosting window to activate itself (it called the
   // JavaScript window.focus() method).
   virtual void Activate() {}
 
   // The contents' preferred size changed.
   virtual void UpdatePreferredSize(const gfx::Size& pref_size) {}
 
-  // The page is trying to open a new page (e.g. a popup window). The window
-  // should be created associated with the given |route_id| in the process of
-  // |source_site_instance|, but it should not be shown yet. That
-  // should happen in response to ShowCreatedWindow.
-  // |params.window_container_type| describes the type of RenderViewHost
-  // container that is requested -- in particular, the window.open call may
-  // have specified 'background' and 'persistent' in the feature string.
-  //
-  // The passed |params.frame_name| parameter is the name parameter that was
-  // passed to window.open(), and will be empty if none was passed.
-  //
-  // Note: this is not called "CreateWindow" because that will clash with
-  // the Windows function which is actually a #define.
-  //
-  // TODO(alexmos): This should be moved to RenderFrameHostDelegate, and the
-  // corresponding IPC message should be sent by the RenderFrame creating the
-  // new window.
-  virtual void CreateNewWindow(
-      SiteInstance* source_site_instance,
-      int32_t route_id,
-      int32_t main_frame_route_id,
-      int32_t main_frame_widget_route_id,
-      const mojom::CreateNewWindowParams& params,
-      SessionStorageNamespace* session_storage_namespace) {}
-
   // The page is trying to open a new widget (e.g. a select popup). The
   // widget should be created associated with the given |route_id| in the
   // process |render_process_id|, but it should not be shown yet. That should
   // happen in response to ShowCreatedWidget.
   // |popup_type| indicates if the widget is a popup and what kind of popup it
   // is (select, autofill...).
   virtual void CreateNewWidget(int32_t render_process_id,
                                int32_t route_id,
                                blink::WebPopupType popup_type) {}
 
   // Creates a full screen RenderWidget. Similar to above.
   virtual void CreateNewFullscreenWidget(int32_t render_process_id,
                                          int32_t route_id) {}
 
-  // Show a previously created page with the specified disposition and bounds.
-  // The window is identified by the route_id passed to CreateNewWindow.
-  //
-  // Note: this is not called "ShowWindow" because that will clash with
-  // the Windows function which is actually a #define.
-  virtual void ShowCreatedWindow(int process_id,
-                                 int route_id,
-                                 WindowOpenDisposition disposition,
-                                 const gfx::Rect& initial_rect,
-                                 bool user_gesture) {}
-
   // Show the newly created widget with the specified bounds.
   // The widget is identified by the route_id passed to CreateNewWidget.
   virtual void ShowCreatedWidget(int process_id,
                                  int route_id,
                                  const gfx::Rect& initial_rect) {}
 
   // Show the newly created full screen widget. Similar to above.
   virtual void ShowCreatedFullscreenWidget(int process_id, int route_id) {}
 
   // Returns the SessionStorageNamespace the render view should use. Might
@@ skipping 36 matching lines @@
   // Whether download UI should be hidden.
   virtual bool HideDownloadUI() const;
 
  protected:
   virtual ~RenderViewHostDelegate() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_