Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2506173004: Add an about://flags entry for enable/disable memory coordinator (Closed)

Created:
4 years, 1 month ago by bashi
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an about://flags entry for enable/disable memory coordinator We need this to enable memory coordinator on locked Android devices. BUG=617492 Committed: https://crrev.com/38bf0fa7b6d998a1afb0117235ad0fa467d934e9 Cr-Commit-Position: refs/heads/master@{#433033}

Patch Set 1 #

Patch Set 2 : Histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
bashi
PTAL chrisha@, haraken@: all cpu@: generated_resources.grd
4 years, 1 month ago (2016-11-17 19:07:37 UTC) #2
haraken
non-owner LGTM
4 years, 1 month ago (2016-11-17 19:16:59 UTC) #3
chrisha
lgtm!
4 years, 1 month ago (2016-11-17 21:42:31 UTC) #4
bashi
Thanks!
4 years, 1 month ago (2016-11-17 21:46:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506173004/1
4 years, 1 month ago (2016-11-17 21:48:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/317465)
4 years, 1 month ago (2016-11-17 22:59:39 UTC) #9
bashi
I added entries to LoginCustomEnum in histograms.xml to fix unittest failures.
4 years, 1 month ago (2016-11-18 00:09:19 UTC) #14
bashi
isherman@: Could you review histograms.xml?
4 years, 1 month ago (2016-11-18 00:11:03 UTC) #16
Ilya Sherman
histograms.xml lgtm
4 years, 1 month ago (2016-11-18 00:13:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506173004/20001
4 years, 1 month ago (2016-11-18 01:12:50 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 02:56:38 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:00:54 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38bf0fa7b6d998a1afb0117235ad0fa467d934e9
Cr-Commit-Position: refs/heads/master@{#433033}

Powered by Google App Engine
This is Rietveld 408576698