[ash-md] Allows ToggleButton to have a border and adds focus rectangle

ash/common/system/tray/tray_constants.cc

Index: ash/common/system/tray/tray_constants.cc
diff --git a/ash/common/system/tray/tray_constants.cc b/ash/common/system/tray/tray_constants.cc
index b0f71b1aa8a6ac99263d12e8a81fd1873212af17..f09b4d9b20ebc5945207da82a9ae174ae71e3743 100644
--- a/ash/common/system/tray/tray_constants.cc
+++ b/ash/common/system/tray/tray_constants.cc
@@ -55,6 +55,9 @@ const SkColor kTrayPopupHoverBackgroundColor = SkColorSetRGB(0xe4, 0xe4, 0xe4);
 const int kTrayPopupScrollSeparatorHeight = 15;
 const int kTrayRoundedBorderRadius = 2;
 
+const int kTrayToggleButtonHorizontalPadding = 14;
+const int kTrayToggleButtonVerticalPadding = 13;

[Evan Stade, 2016/11/17 23:24:36]

can we calculate this? Should be more robust that way (to changes in
ToggleButton, for example.

e.g. (popup_item_min_height - toggle_button->GetPreferredSize().height()) / 2;

[varkha, 2016/11/17 23:40:51]

I'd like to but I am not sure how to do that without exposing GetPreferredSize
to code in ash/.../system/tray. Would querying toggle->size() work upon
creation?

[varkha, 2016/11/18 00:00:34]

See if this change works - I think 68 is the dimension that is in the mocks and
I made GetVisibleSize visible from ToggleButton.

[Evan Stade, 2016/11/18 00:20:21]

I was really only talking about the height, as the width padding really is a
magic number (unless we can reuse the vertical padding number we calculate ---
they seem very close).

[varkha, 2016/11/18 01:13:40]

I think it is easier to have the horizontal size based on the full size (same as
kMenuButtonSize) rather than insets.
Yes, the insets end up similar and only different (I think) because we need to
reserve space for shadow and because (I am guessing here) you wanted the heights
and insets to be whole numbers for accurate layout.

+
 const SkColor kBackgroundColor = SkColorSetRGB(0xfe, 0xfe, 0xfe);
 const SkColor kHoverBackgroundColor = SkColorSetRGB(0xf3, 0xf3, 0xf3);
 const SkColor kPublicAccountBackgroundColor = SkColorSetRGB(0xf8, 0xe5, 0xb6);