PaymentApp: Implement PaymentAppManager.getManifest().

content/browser/payments/payment_app_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_MANAGER_H_
 #define CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_MANAGER_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 12 matching lines @@
     : public NON_EXPORTED_BASE(payments::mojom::PaymentAppManager) {
  public:
   PaymentAppManager(
       PaymentAppContext* payment_app_context,
       mojo::InterfaceRequest<payments::mojom::PaymentAppManager> request);
 
   ~PaymentAppManager() override;
 
  private:
   friend class PaymentAppManagerTest;
+
   // payments::mojom::PaymentAppManager methods:
   void SetManifest(const std::string& scope,
                    payments::mojom::PaymentAppManifestPtr manifest,
                    const SetManifestCallback& callback) override;
   void DidFindRegistrationToSetManifest(
       payments::mojom::PaymentAppManifestPtr manifest,
       const SetManifestCallback& callback,
       ServiceWorkerStatusCode status,
       scoped_refptr<ServiceWorkerRegistration> registration);
   void DidSetManifest(const SetManifestCallback& callback,
                       ServiceWorkerStatusCode status);
 
+  void GetManifest(const std::string& scope,
+                   const GetManifestCallback& callback) override;

[please use gerrit instead, 2016/11/21 22:02:13]

Please put only SetManifest() and GetManifest() in "//
payments::mojom::PaymentAppManager" section and nothing else.

[zino, 2016/11/21 23:48:40]

Done.

+  void DidFindRegistrationToGetManifest(
+      const GetManifestCallback& callback,
+      ServiceWorkerStatusCode status,
+      scoped_refptr<ServiceWorkerRegistration> registration);
+  void DidGetManifest(const GetManifestCallback& callback,
+                      const std::vector<std::string>& data,
+                      ServiceWorkerStatusCode status);
+
   // Called when an error is detected on binding_.
   void OnConnectionError();
 
   // payment_app_context_ owns this.

[please use gerrit instead, 2016/11/21 22:02:13]

"this" is confusing here. I guess you wanted to say something lke
"PaymentAppContext owns PaymentAppManager".

[zino, 2016/11/21 23:48:40]

Done.

   PaymentAppContext* payment_app_context_;
 
   mojo::Binding<payments::mojom::PaymentAppManager> binding_;
 
   base::WeakPtrFactory<PaymentAppManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentAppManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_MANAGER_H_