Continue formatting fwl/core

Continue formatting fwl/core

Committed: https://pdfium.googlesource.com/pdfium/+/14a60c50b10de1d9e4edd3629ea210a816940a75

[dsinclair, 2016-11-16 16:56:20]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-16 16:56:21]

PTAL.

https://codereview.chromium.org/2506083002/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
File xfa/fxfa/app/xfa_ffchoicelist.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
xfa/fxfa/app/xfa_ffchoicelist.cpp:442: void CXFA_FFComboBox::SelectAll() {
This file is a mess, but I'm ignoring it for now.

[dsinclair, 2016-11-16 16:56:22]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 16:56:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 17:11:00]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-16 18:37:57]

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:904: Repaint(&m_rtClient);
nit: you could make this be in the if instead of the if above
if (!IsDrop .. || ! pMsg ..) {
  Repaint(&m_rtClient);
  return
}
...

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox.h
File xfa/fwl/core/ifwl_combobox.h (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.h:118: bool EditCanCut() const {
These are 3 lines, why move to header file?

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combolist...
File xfa/fwl/core/ifwl_combolist.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combolist...
xfa/fwl/core/ifwl_combolist.cpp:215: return 1;
So this always returns 1?

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:134: int32_t
IFWL_DateTimePicker::GetSelRange(int32_t nIndex,
If you're moving one-liners to headers, you could move these two

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:315: switch (m_pProperties->m_dwStyleExes &
FWL_STYLEEXT_DTP_EditHAlignMask) {
Don't see why we need to remove the dwStylExes variable, given it is used
several times. Now, we have to make sure that m_pProperties->m_dwStyleExes is
not modified throughout the method.

https://codereview.chromium.org/2506083002/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
File xfa/fxfa/app/xfa_ffchoicelist.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
xfa/fxfa/app/xfa_ffchoicelist.cpp:442: void CXFA_FFComboBox::SelectAll() {
On 2016/11/16 16:56:21, dsinclair wrote:
> This file is a mess, but I'm ignoring it for now.

Acknowledged.

[dsinclair, 2016-11-16 18:57:11]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[dsinclair, 2016-11-16 18:57:14]

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:904: Repaint(&m_rtClient);
On 2016/11/16 18:37:57, npm wrote:
> nit: you could make this be in the if instead of the if above
> if (!IsDrop .. || ! pMsg ..) {
>   Repaint(&m_rtClient);
>   return
> }
> ...

Done.

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox.h
File xfa/fwl/core/ifwl_combobox.h (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.h:118: bool EditCanCut() const {
On 2016/11/16 18:37:57, npm wrote:
> These are 3 lines, why move to header file?

To keep it consistent with the other Edit* methods that moved over. They're a
pretty simple check.

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combolist...
File xfa/fwl/core/ifwl_combolist.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_combolist...
xfa/fwl/core/ifwl_combolist.cpp:215: return 1;
On 2016/11/16 18:37:57, npm wrote:
> So this always returns 1?

Nice catch. Not anymore.

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:134: int32_t
IFWL_DateTimePicker::GetSelRange(int32_t nIndex,
On 2016/11/16 18:37:57, npm wrote:
> If you're moving one-liners to headers, you could move these two

Done.

https://codereview.chromium.org/2506083002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:315: switch (m_pProperties->m_dwStyleExes &
FWL_STYLEEXT_DTP_EditHAlignMask) {
On 2016/11/16 18:37:57, npm wrote:
> Don't see why we need to remove the dwStylExes variable, given it is used
> several times. Now, we have to make sure that m_pProperties->m_dwStyleExes is
> not modified throughout the method.


Seems a bit clearer. The method only ever modifies dwAdd to what I can see up to
the very end.

[commit-bot: I haz the power, 2016-11-16 18:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:17:42]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-16 20:13:09]

lgtm

[dsinclair, 2016-11-16 20:15:01]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-16 20:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:15:30]

Description was changed from

==========
Continue formatting fwl/core
==========

to

==========
Continue formatting fwl/core

Committed:
https://pdfium.googlesource.com/pdfium/+/14a60c50b10de1d9e4edd3629ea210a81694...
==========

[commit-bot: I haz the power, 2016-11-16 20:15:32]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/14a60c50b10de1d9e4edd3629ea210a81694...