Issue 2506033002: VM: Remove _nativeScript external. JS has no equivalent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2506033002: VM: Remove _nativeScript external. JS has no equivalent. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
4 years, 1 month ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Remove _nativeScript external. JS has no equivalent. It was added to @patch member in the VM patches. The right fix is to remove @patch annotation from the _nativeScript. TBR=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6f1efe295cff0e0d4b6398c398aae8013bb6b997

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	runtime/bin/platform_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/io/platform_impl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Vyacheslav Egorov (Google)

4 years, 1 month ago (2016-11-16 15:36:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6f1efe295cff0e0d4b6398c398aae8013bb6b997 (presubmit successful).