Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2506013002: Revert of Run gl_unittests with Ozone X11. (Closed)

Created:
4 years, 1 month ago by tandrii(chromium)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run gl_unittests with Ozone X11. (patchset #3 id:40001 of https://codereview.chromium.org/2493063003/ ) Reason for revert: Likely caused error in isolate steps in http://crbug.com/665895: /b/c/b/linux_chromeos/src/out/Release/xdisplaycheck: no such file or directory Original issue's description: > Run gl_unittests with Ozone X11. > > Add a new test target gl_unittests_ozonex that runs with > --ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with > both Ozone headless and Ozone X11. > > The test requires an X server to be running on the bot. The mb.py script > is modified to look for GN arg use_ozone=true and runtime flag > --ozone-platform=x11. In this case, it runs the test using xvfb. > > BUG=664570 > > Committed: https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df > Cr-Commit-Position: refs/heads/master@{#432038} TBR=dpranke@chromium.org,sadrul@chromium.org,kylechar@chromium.org # tandrii@ decided it's enough waiting for tests. # so not (Not skipping CQ checks because original CL landed more than 1 days ago.) NOTRY=True BUG=664570, 665895 Committed: https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2 Cr-Commit-Position: refs/heads/master@{#432513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -40 lines) Patch
M BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 2 chunks +1 line, -9 lines 0 comments Download
M tools/mb/mb.py View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tandrii(chromium)
Created Revert of Run gl_unittests with Ozone X11.
4 years, 1 month ago (2016-11-16 15:15:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506013002/1
4 years, 1 month ago (2016-11-16 15:16:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 16:34:01 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2 Cr-Commit-Position: refs/heads/master@{#432513}
4 years, 1 month ago (2016-11-16 16:38:15 UTC) #10
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-16 17:27:45 UTC) #11
kylechar
4 years, 1 month ago (2016-11-16 17:32:14 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698