Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2506003002: Turn off shared function info-based optimization. (Closed)

Created:
4 years, 1 month ago by mvstanton
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn off shared function info-based optimization. In order to address a performance issue. BUG=v8:5512, chromium:664937 Committed: https://crrev.com/1006bd7172fec2ce5c82813ef4e8e4379e27a599 Cr-Commit-Position: refs/heads/master@{#41041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mvstanton
Hi Jaro, We'll have to revert this flag flip until addressing the weak-code deopt issues. ...
4 years, 1 month ago (2016-11-16 14:58:51 UTC) #2
Jarin
lgtm
4 years, 1 month ago (2016-11-16 14:59:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506003002/1
4 years, 1 month ago (2016-11-16 15:02:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 15:26:11 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1006bd7172fec2ce5c82813ef4e8e4379e27a599
Cr-Commit-Position: refs/heads/master@{#41041}

Powered by Google App Engine
This is Rietveld 408576698