Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: components/arc/common/intent_helper.mojom

Issue 2505993005: Move FS related mojo methods to ArcFileSystemInstance. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/intent_helper.mojom
diff --git a/components/arc/common/intent_helper.mojom b/components/arc/common/intent_helper.mojom
index 1bc7c4558f9da9d7210c9826d79f714c69c34880..e8911f93af028bef5e369020a0fed9853716db50 100644
--- a/components/arc/common/intent_helper.mojom
+++ b/components/arc/common/intent_helper.mojom
@@ -116,7 +116,7 @@ interface IntentHelperInstance {
// When multiple packages are set as preferred, the most recent setting wins.
[MinVersion=7] AddPreferredPackage@8(string package_name);
- // Asks the ContentResolver for the size of the file specified by the URL.
+ // DEPRECATED. Use FileSystemInstance.GetFileSize() instead.
[MinVersion=15] GetFileSize@11(string url) => (int64 size);
Luis Héctor Chávez 2016/11/18 16:37:53 Can you add the Deprecated suffix to this method p
Shuhei Takahashi 2016/11/21 11:06:29 Sure, done.
// Passes an intent to an activity.
@@ -134,8 +134,7 @@ interface IntentHelperInstance {
// Establishes full-duplex communication with the host.
Init@0(IntentHelperHost host_ptr);
- // Asks the ContentResolver to get an FD to read the file specified by the
- // URL.
+ // DEPRECATED. Use FileSystemInstance.OpenFileToRead() instead.
[MinVersion=15] OpenFileToRead@12(string url) => (handle? fd);
Yusuke Sato 2016/11/18 19:09:38 same, OpenFileToReadDeprecated
Shuhei Takahashi 2016/11/21 11:06:29 Done.
// Requests 48dp * 48dp icons of the |activities| suitable for the
« components/arc/common/file_system.mojom ('K') | « components/arc/common/file_system.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698