Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2505973004: MD Settings: Add route for the Import Data dialog at /importData. (Closed)

Created:
4 years, 1 month ago by tommycli
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add route for the Import Data dialog at /importData. BUG=666035 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/de32677904b9842102af5c93b9ea5db119b3c5f4 Cr-Commit-Position: refs/heads/master@{#432903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.js View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tommycli
dpapad: follows same pattern as other navigable dialogs, such as clear browsing data
4 years, 1 month ago (2016-11-16 22:01:20 UTC) #3
tommycli
On 2016/11/16 22:01:20, tommycli wrote: > dpapad: follows same pattern as other navigable dialogs, such ...
4 years, 1 month ago (2016-11-16 22:01:32 UTC) #4
dpapad
lgtm
4 years, 1 month ago (2016-11-16 22:06:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505973004/1
4 years, 1 month ago (2016-11-16 22:08:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/69259)
4 years, 1 month ago (2016-11-17 00:39:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505973004/1
4 years, 1 month ago (2016-11-17 16:35:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 17:46:20 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:08:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de32677904b9842102af5c93b9ea5db119b3c5f4
Cr-Commit-Position: refs/heads/master@{#432903}

Powered by Google App Engine
This is Rietveld 408576698