Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2505973003: harmony: use Harmony sizing for ViewsDelegate sizing functions (Closed)

Created:
4 years, 1 month ago by Elly Fong-Jones
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

harmony: use Harmony sizing for ViewsDelegate sizing functions BUG=635173 Committed: https://crrev.com/50ef64ec787d2d721df865f74c22596e2ac0601e Cr-Commit-Position: refs/heads/master@{#433946}

Patch Set 1 #

Total comments: 1

Patch Set 2 : move constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.cc View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Elly Fong-Jones
sky: ptal? :)
4 years, 1 month ago (2016-11-17 14:36:40 UTC) #3
sky
LGTM https://codereview.chromium.org/2505973003/diff/1/chrome/browser/ui/views/harmony/harmony_layout_delegate.h File chrome/browser/ui/views/harmony/harmony_layout_delegate.h (right): https://codereview.chromium.org/2505973003/diff/1/chrome/browser/ui/views/harmony/harmony_layout_delegate.h#newcode19 chrome/browser/ui/views/harmony/harmony_layout_delegate.h:19: static const int kHarmonyLayoutUnit = 16; style guide ...
4 years, 1 month ago (2016-11-17 18:18:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505973003/20001
4 years, 1 month ago (2016-11-22 15:47:13 UTC) #7
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 1 month ago (2016-11-22 18:12:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505973003/20001
4 years, 1 month ago (2016-11-22 19:37:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 19:48:55 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 19:52:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50ef64ec787d2d721df865f74c22596e2ac0601e
Cr-Commit-Position: refs/heads/master@{#433946}

Powered by Google App Engine
This is Rietveld 408576698