Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2505963003: Revert of Enable WebVR for non component build (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
bshe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ ) Reason for revert: Reverting until dex size growth is understood. Original issue's description: > Enable Android WebVR for arm & arm64 > > BUG=644785 > > Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 > Cr-Commit-Position: refs/heads/master@{#432489} TBR=bshe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644785 Committed: https://crrev.com/19ef7689f208ee3222539bf0bb1d4054b2dbf780 Cr-Commit-Position: refs/heads/master@{#432606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/config/features.gni View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
Created Revert of Enable WebVR for non component build
4 years, 1 month ago (2016-11-16 20:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505963003/1
4 years, 1 month ago (2016-11-16 20:10:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 20:11:55 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19ef7689f208ee3222539bf0bb1d4054b2dbf780 Cr-Commit-Position: refs/heads/master@{#432606}
4 years, 1 month ago (2016-11-16 20:24:43 UTC) #6
bshe
4 years, 1 month ago (2016-11-17 03:25:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2505313002/ by bshe@chromium.org.

The reason for reverting is: Hi Andrew.
It turns out that our UX review is blocked on this. We need it in canary build.
I will revert your revert for now. And I will work with you tomorrow to figure
out if there is a way to reduce dex size of gvr. There should be enough time to
land/merge these improvements before it hits stable.
Anyway, let's talk tomorrow. Thanks!.

Powered by Google App Engine
This is Rietveld 408576698