Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2505953002: [ios] Adds test provider implementations. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds test provider implementations. Adds test implementations for the following providers: InfobarViewProtocol LiveTabContextProvider SyncedWindowDelegatesGetter This keeps with the rule that sub-providers must always exist, to prevent production code from having to check for NULL everywhere. BUG=665591 Committed: https://crrev.com/a51b0d005ed8905f6f92b526094abd3fb4fbdd35 Cr-Commit-Position: refs/heads/master@{#432651}

Patch Set 1 #

Patch Set 2 : GN. #

Patch Set 3 : Fix build file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -12 lines) Patch
M ios/public/provider/chrome/browser/BUILD.gn View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/sessions/test_live_tab_context_provider.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.mm View 4 chunks +22 lines, -11 lines 0 comments Download
M ios/public/provider/chrome/browser/ui/infobar_view_protocol.h View 1 chunk +1 line, -1 line 0 comments Download
A ios/public/provider/chrome/browser/ui/test_infobar_view.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/ui/test_infobar_view.mm View 1 chunk +62 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/ui/test_styled_text_field.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/ui/test_styled_text_field.mm View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-16 14:08:47 UTC) #11
sdefresne
lgtm
4 years, 1 month ago (2016-11-16 16:50:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505953002/40001
4 years, 1 month ago (2016-11-16 16:51:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316079)
4 years, 1 month ago (2016-11-16 20:58:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505953002/40001
4 years, 1 month ago (2016-11-16 21:26:03 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 22:40:51 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 22:43:21 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a51b0d005ed8905f6f92b526094abd3fb4fbdd35
Cr-Commit-Position: refs/heads/master@{#432651}

Powered by Google App Engine
This is Rietveld 408576698