Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ui/views/controls/textfield/textfield_unittest.cc

Issue 2505943002: MacViews: Fix accelerator handling while Omnibox is in focus. (Closed)
Patch Set: Fixed TextfieldTest.*, disable ViewTest.ActivateAcceleratorOnMac on non-MacViews. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index 13e2b3da54dfca41c97d94a5298f8379ffd172ca..d22c7e83cf23ca87603f5c459a225b462409334f 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -1252,13 +1252,7 @@ TEST_F(TextfieldTest, OnKeyPress) {
// F20 key won't be handled.
SendKeyEvent(ui::VKEY_F20);
-#if defined(OS_MACOSX)
- // On Mac, key combinations that don't map to editing commands are forwarded
- // on to the next responder, usually ending up at the window, which will beep.
tapted 2016/11/23 02:09:30 this is nice :)
- EXPECT_FALSE(textfield_->key_received());
themblsha 2016/11/22 14:33:48 The comment is outdated, as we try to DispatchKeyE
-#else
EXPECT_TRUE(textfield_->key_received());
-#endif
EXPECT_FALSE(textfield_->key_handled());
textfield_->clear();
}

Powered by Google App Engine
This is Rietveld 408576698