MacViews: Fix accelerator handling while Omnibox is in focus.

ui/events/test/event_generator.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_TEST_EVENT_GENERATOR_H_
 #define UI_EVENTS_TEST_EVENT_GENERATOR_H_
 
 #include <list>
 #include <memory>
 #include <vector>
@@ skipping 116 matching lines @@
   // various methods that take a location but can be manipulated directly,
   // typically for touch.
   void set_current_location(const gfx::Point& location) {
     current_location_ = location;
   }
   const gfx::Point& current_location() const { return current_location_; }
 
   void set_async(bool async) { async_ = async; }
   bool async() const { return async_; }
 
-  // Dispatch events through the application instead of directly to the
-  // target window. Currently only supported on Mac.
-  void set_targeting_application(bool targeting_application) {
-    targeting_application_ = targeting_application;
-  }
-  bool targeting_application() const { return targeting_application_; }
+  // Events could be dispatched using different methods. The choice is a
+  // tradeoff between test robustness and coverage of OS internals that affect
+  // event dispatch.
+  // Currently only supported on Mac.
+  enum class Target {
+    // Dispatch through the application. Least robust.
+    APPLICATION,
+    // Dispatch directly to target window.
+    WINDOW,
+    // Default. Emulates default Window dispatch. Most robust.
+    WIDGET,

[sadrul, 2016/11/21 16:30:53]

The difference between WINDOW and WIDGET isn't really clear. Mind clarifying
that in the comment here?

Can you also mention that it is used only on mac?

[themblsha, 2016/11/21 17:02:20]

Made the comments more verbose. "Currently only supported on Mac." is mentioned
on top of the enum and applies to all the cases. Is it not prominent enough?

[sadrul, 2016/11/21 18:11:33]

Whoops, I missed that comment :)

+  };
+
+  // Selects dispatch method. Currently only supported on Mac.
+  void set_target(Target target) { target_ = target; }
+  Target target() const { return target_; }
 
   // Resets the event flags bitmask.
   void set_flags(int flags) { flags_ = flags; }
   int flags() const { return flags_; }
 
   // Generates a left button press event.
   void PressLeftButton();
 
   // Generates a left button release event.
   void ReleaseLeftButton();
@@ skipping 250 matching lines @@
 
   std::unique_ptr<EventGeneratorDelegate> delegate_;
   gfx::Point current_location_;
   EventTarget* current_target_;
   int flags_;
   bool grab_;
   bool pen_pointer_mode_ = false;
   std::list<std::unique_ptr<Event>> pending_events_;
   // Set to true to cause events to be posted asynchronously.
   bool async_;
-  bool targeting_application_;
+  Target target_;
   std::unique_ptr<base::TickClock> tick_clock_;
 
   DISALLOW_COPY_AND_ASSIGN(EventGenerator);
 };
 
 }  // namespace test
 }  // namespace ui
 
 #endif  // UI_EVENTS_TEST_EVENT_GENERATOR_H_