Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2505933009:
[ObjC ARC] Converts ios/chrome/browser/voice:tts to ARC.Automatically generated ARCMigrate commit… (Closed)
|
Created:
4 years, 1 month ago by stkhapugin Modified:
4 years ago CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/voice:tts to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Committed: https://crrev.com/e84bdf15a68877a3a2962abaeb0827081a7ca17d
Cr-Commit-Position: refs/heads/master@{#436296}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed weak_nsobject boilerplate #
Total comments: 2
Patch Set 3 : make_unique #
Messages
Total messages: 31 (18 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + noyau@chromium.org
PTAL. Passes downstream tests.
https://codereview.chromium.org/2505933009/diff/1/ios/chrome/browser/voice/te... File ios/chrome/browser/voice/text_to_speech_listener.mm (left): https://codereview.chromium.org/2505933009/diff/1/ios/chrome/browser/voice/te... ios/chrome/browser/voice/text_to_speech_listener.mm:84: base::WeakNSProtocol<id<TextToSpeechListenerDelegate>> _delegate; Why don't you remove all that code? Everything related to the delegate can simply use the weak property.
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thanks, ptal https://codereview.chromium.org/2505933009/diff/1/ios/chrome/browser/voice/te... File ios/chrome/browser/voice/text_to_speech_listener.mm (left): https://codereview.chromium.org/2505933009/diff/1/ios/chrome/browser/voice/te... ios/chrome/browser/voice/text_to_speech_listener.mm:84: base::WeakNSProtocol<id<TextToSpeechListenerDelegate>> _delegate; On 2016/11/21 14:15:03, noyau wrote: > Why don't you remove all that code? Everything related to the delegate can > simply use the weak property. Done.
sdefresne@chromium.org changed reviewers: + sdefresne@chromium.org
lgtm https://codereview.chromium.org/2505933009/diff/20001/ios/chrome/browser/voic... File ios/chrome/browser/voice/text_to_speech_listener.mm (right): https://codereview.chromium.org/2505933009/diff/20001/ios/chrome/browser/voic... ios/chrome/browser/voice/text_to_speech_listener.mm:95: _webStateObserver.reset(new TextToSpeechWebStateObserver(webState, self)); nit: can you change this to base::MakeUnique<>?
Thanks! https://codereview.chromium.org/2505933009/diff/20001/ios/chrome/browser/voic... File ios/chrome/browser/voice/text_to_speech_listener.mm (right): https://codereview.chromium.org/2505933009/diff/20001/ios/chrome/browser/voic... ios/chrome/browser/voice/text_to_speech_listener.mm:95: _webStateObserver.reset(new TextToSpeechWebStateObserver(webState, self)); On 2016/11/22 14:35:39, sdefresne wrote: > nit: can you change this to base::MakeUnique<>? Done.
The CQ bit was checked by stkhapugin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2505933009/#ps40001 (title: "make_unique")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480949432567140,
"parent_rev": "ab70842cf7205eec8ea9702bea044117dfbae1fb", "commit_rev":
"18fc6d0b5215bbdcab46c858c73d3d6f9dd9aa66"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/voice:tts to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/voice:tts to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/e84bdf15a68877a3a2962abaeb0827081a7ca17d Cr-Commit-Position: refs/heads/master@{#436296} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e84bdf15a68877a3a2962abaeb0827081a7ca17d Cr-Commit-Position: refs/heads/master@{#436296} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
