Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: test/cctest/compiler/function-tester.cc

Issue 2505933008: [compiler] Ensure code unsupported by Crankshaft goes to Ignition. (Closed)
Patch Set: Update FunctionTester Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/function-tester.cc
diff --git a/test/cctest/compiler/function-tester.cc b/test/cctest/compiler/function-tester.cc
index bee8f63312b954950440c70198ebeedcfbbc16c7..c28581575439041437242affa68e6581fb76f471 100644
--- a/test/cctest/compiler/function-tester.cc
+++ b/test/cctest/compiler/function-tester.cc
@@ -164,12 +164,11 @@ Handle<JSFunction> FunctionTester::Compile(Handle<JSFunction> function) {
if (flags_ & CompilationInfo::kInliningEnabled) {
info.MarkAsInliningEnabled();
}
- if (Compiler::EnsureBytecode(&info)) {
- info.MarkAsOptimizeFromBytecode();
- } else {
- CHECK(Compiler::ParseAndAnalyze(info.parse_info()));
- CHECK(Compiler::EnsureDeoptimizationSupport(&info));
- }
+
+ info.shared_info()->set_dont_crankshaft(true);
+ CHECK(Compiler::EnsureBytecode(&info));
+ info.MarkAsOptimizeFromBytecode();
rmcilroy 2016/11/18 15:29:23 I updated this as well to ensure we always go thro
+
JSFunction::EnsureLiterals(function);
Handle<Code> code = Pipeline::GenerateCodeForTesting(&info);
« no previous file with comments | « src/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698