[compiler] Ensure code unsupported by Crankshaft goes to Ignition.

test/cctest/compiler/function-tester.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/cctest/compiler/function-tester.h"
 
 #include "src/ast/ast-numbering.h"
 #include "src/compilation-info.h"
 #include "src/compiler.h"
 #include "src/compiler/linkage.h"
@@ skipping 146 matching lines @@
 Handle<JSFunction> FunctionTester::Compile(Handle<JSFunction> function) {
   Zone zone(function->GetIsolate()->allocator(), ZONE_NAME);
   ParseInfo parse_info(&zone, handle(function->shared()));
   CompilationInfo info(&parse_info, function);
 
   info.SetOptimizing();
   info.MarkAsDeoptimizationEnabled();
   if (flags_ & CompilationInfo::kInliningEnabled) {
     info.MarkAsInliningEnabled();
   }
-  if (Compiler::EnsureBytecode(&info)) {
-    info.MarkAsOptimizeFromBytecode();
-  } else {
-    CHECK(Compiler::ParseAndAnalyze(info.parse_info()));
-    CHECK(Compiler::EnsureDeoptimizationSupport(&info));
-  }
+
+  info.shared_info()->set_dont_crankshaft(true);
+  CHECK(Compiler::EnsureBytecode(&info));
+  info.MarkAsOptimizeFromBytecode();

[rmcilroy, 2016/11/18 15:29:23]

I updated this as well to ensure we always go through the BytecodeGraphBuilder
for FunctionTester (since some bits being tested, e.g., Eval, will be ripped out
of FCG / the ASTGraphBuilder soon).

+
   JSFunction::EnsureLiterals(function);
 
   Handle<Code> code = Pipeline::GenerateCodeForTesting(&info);
   CHECK(!code.is_null());
   info.dependencies()->Commit(code);
   info.context()->native_context()->AddOptimizedCode(*code);
   function->ReplaceCode(*code);
   return function;
 }
 
 // Compile the given machine graph instead of the source of the function
 // and replace the JSFunction's code with the result.
 Handle<JSFunction> FunctionTester::CompileGraph(Graph* graph) {
   Zone zone(function->GetIsolate()->allocator(), ZONE_NAME);
   ParseInfo parse_info(&zone, handle(function->shared()));
   CompilationInfo info(&parse_info, function);
 
   CHECK(Parser::ParseStatic(info.parse_info()));
   info.SetOptimizing();
 
   Handle<Code> code = Pipeline::GenerateCodeForTesting(&info, graph);
   CHECK(!code.is_null());
   function->ReplaceCode(*code);
   return function;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8