[compiler] Ensure code unsupported by Crankshaft goes to Ignition.

src/runtime/runtime-test.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include <memory>
 
 #include "src/arguments.h"
 #include "src/compiler-dispatcher/optimizing-compile-dispatcher.h"
@@ skipping 109 matching lines @@
   Handle<JSFunction> function = Handle<JSFunction>::cast(function_object);
 
   // The following condition was lifted from the DCHECK inside
   // JSFunction::MarkForOptimization().
   if (!(function->shared()->allows_lazy_compilation() ||
         (function->code()->kind() == Code::FUNCTION &&
          !function->shared()->optimization_disabled()))) {
     return isolate->heap()->undefined_value();
   }
 
+  // If function isn't compiled, compile it now.
+  if (!function->is_compiled() &&

[Michael Starzinger, 2016/11/22 14:53:50]

Would it be possible to check whether {function->shared()->is_compiled()} here
instead? Note that {Compiler::Compile} already has the appropriate
post-condition check for {function->shared()->is_compiled()} in place. WDYT?

Also I would move this to after the quick-check for {function->IsOptimized()}
below (i.e. 3 lines down).

[rmcilroy, 2016/11/22 17:24:02]

Done.
This is what I had originally but it doesn't work because when --always-opt is
enabled the Compiler::Compile causes the code to get optimized, and
MarkForOptimization fails due to the code already being optimized.

+      !Compiler::Compile(function, Compiler::CLEAR_EXCEPTION)) {
+    return isolate->heap()->undefined_value();
+  }
+
   // If the function is already optimized, just return.
   if (function->IsOptimized()) return isolate->heap()->undefined_value();
 
   function->MarkForOptimization();
 
   Code* unoptimized = function->shared()->code();
   if (args.length() == 2 && unoptimized->kind() == Code::FUNCTION) {
     CONVERT_ARG_HANDLE_CHECKED(String, type, 1);
     if (type->IsOneByteEqualTo(STATIC_CHAR_VECTOR("concurrent")) &&
         isolate->concurrent_recompilation_enabled()) {
@@ skipping 675 matching lines @@
 RUNTIME_FUNCTION(Runtime_ValidateWasmOrphanedInstance) {
   HandleScope shs(isolate);
   DCHECK(args.length() == 1);
   CONVERT_ARG_HANDLE_CHECKED_2(WasmInstanceObject, instance, 0);
   wasm::testing::ValidateOrphanedInstance(isolate, instance);
   return isolate->heap()->ToBoolean(true);
 }
 
 }  // namespace internal
 }  // namespace v8