Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2505933007: Enable MarkNonSecureAs experiment on waterfall (Closed)

Created:
4 years, 1 month ago by estark
Modified:
4 years, 1 month ago
Reviewers:
Steven Holte
CC:
chromium-reviews, elawrence
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable MarkNonSecureAs experiment on waterfall BUG=647754 Committed: https://crrev.com/6afd74e4569d5546bd21853cff45a058f5f8f036 Cr-Commit-Position: refs/heads/master@{#433346}

Patch Set 1 #

Patch Set 2 : make browser test default explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
estark
holte: PTAL, thanks!
4 years, 1 month ago (2016-11-18 06:59:04 UTC) #4
Steven Holte
lgtm
4 years, 1 month ago (2016-11-18 19:44:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505933007/20001
4 years, 1 month ago (2016-11-18 23:52:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-19 00:18:56 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:29:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6afd74e4569d5546bd21853cff45a058f5f8f036
Cr-Commit-Position: refs/heads/master@{#433346}

Powered by Google App Engine
This is Rietveld 408576698