Auto-Generating Search Engines - Remove HTTP Restriction

third_party/WebKit/Source/web/WebSearchableFormData.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 48 matching lines @@
   str.split(' ', charsets);
   for (const String& charset : charsets) {
     *encoding = WTF::TextEncoding(charset);
     if (encoding->isValid())
       return;
   }
   if (form.document().loader())
     *encoding = WTF::TextEncoding(form.document().encoding());
 }
 
-// Returns true if the submit request results in an HTTP URL.
-bool isHTTPFormSubmit(const HTMLFormElement& form) {
-  // FIXME: This function is insane. This is an overly complicated way to get
-  // this information.
-  String action(form.action());
-  // The isNull() check is trying to avoid completeURL returning KURL() when
-  // passed a null string.
-  return form.document()
-      .completeURL(action.isNull() ? "" : action)
-      .protocolIs("http");
-}
-
 // If the form does not have an activated submit button, the first submit
 // button is returned.
 HTMLFormControlElement* buttonToActivate(const HTMLFormElement& form) {
   HTMLFormControlElement* firstSubmitButton = nullptr;
   for (auto& element : form.associatedElements()) {
     if (!element->isFormControlElement())
       continue;
     HTMLFormControlElement* control = toHTMLFormControlElement(element);
     if (control->isActivatedSubmit()) {
       // There's a button that is already activated for submit, return
@@ skipping 137 matching lines @@
 }  // namespace
 
 WebSearchableFormData::WebSearchableFormData(
     const WebFormElement& form,
     const WebInputElement& selectedInputElement) {
   HTMLFormElement* formElement = static_cast<HTMLFormElement*>(form);
   HTMLInputElement* inputElement =
       static_cast<HTMLInputElement*>(selectedInputElement);
 
   // Only consider forms that GET data.
-  // Allow HTTPS only when an input element is provided.
-  if (equalIgnoringASCIICase(formElement->getAttribute(methodAttr), "post") ||
-      (!isHTTPFormSubmit(*formElement) && !inputElement))
+  if (equalIgnoringASCIICase(formElement->getAttribute(methodAttr), "post"))
     return;
 
   WTF::TextEncoding encoding;
   getFormEncoding(*formElement, &encoding);
   if (!encoding.isValid()) {
     // Need a valid encoding to encode the form elements.
     // If the encoding isn't found webkit ends up replacing the params with
     // empty strings. So, we don't try to do anything here.
     return;
   }
@@ skipping 29 matching lines @@
 
   String action(formElement->action());
   KURL url(formElement->document().completeURL(action.isNull() ? "" : action));
   RefPtr<EncodedFormData> formData = EncodedFormData::create(encodedString);
   url.setQuery(formData->flattenToString());
   m_url = url;
   m_encoding = String(encoding.name());
 }
 
 }  // namespace blink