Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 250593004: Change HarfBuzz selectionRect rounding to match simple text version (Closed)

Created:
6 years, 8 months ago by eae
Modified:
6 years, 8 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Change HarfBuzz selectionRect rounding to match simple text version Change the HarfBuzzShaper::selectionRect rounding logic to match that of selectionRectForSimpleText. This ensures consistent rounding for selection rects and avoids selection gaps due to inconsistent rounding. BUG=366705 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172546

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
eae
6 years, 8 months ago (2014-04-24 16:36:38 UTC) #1
dglazkov
lgtm
6 years, 8 months ago (2014-04-24 17:00:00 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-24 17:01:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/250593004/1
6 years, 8 months ago (2014-04-24 17:01:22 UTC) #4
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-24 17:03:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/250593004/20001
6 years, 8 months ago (2014-04-24 17:04:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 17:24:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-24 17:24:51 UTC) #8
eae
The CQ bit was checked by eae@chromium.org
6 years, 8 months ago (2014-04-24 19:40:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/250593004/20001
6 years, 8 months ago (2014-04-24 19:41:17 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:06:11 UTC) #11
Message was sent while issue was closed.
Change committed as 172546

Powered by Google App Engine
This is Rietveld 408576698