Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250593003: [Telemetry] Enable the measurement smoke test on android. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 7 months ago
Reviewers:
bulach
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Enable the measurement smoke test on android. This required disabling the benchmarks that were causing it to fail. It looks like those failures were due to lack of tab support in ChromeShell. BUG=337829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/perf/benchmarks/memory_pressure.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/benchmarks/tab_switching.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/measurement_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tonyg
6 years, 8 months ago (2014-04-24 14:19:40 UTC) #1
bulach
lgtm, thanks!
6 years, 8 months ago (2014-04-24 16:25:26 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-24 16:28:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/250593003/1
6 years, 8 months ago (2014-04-24 16:28:42 UTC) #4
tonyg
The CQ bit was unchecked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 03:26:45 UTC) #5
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 03:26:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/250593003/1
6 years, 8 months ago (2014-04-26 03:27:52 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 09:59:03 UTC) #8
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-26 09:59:03 UTC) #9
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 13:32:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/250593003/1
6 years, 8 months ago (2014-04-26 13:33:06 UTC) #11
commit-bot: I haz the power
Change committed as 266457
6 years, 7 months ago (2014-04-28 06:59:22 UTC) #12
Michael Achenbach
6 years, 7 months ago (2014-04-28 11:56:11 UTC) #13
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/256123002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This is failing on android now (slightly
after its activation, but I can't figure out the actual culprit):
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698