MIPS64: Port "Reland of "MIPS: Optimize load/store with large offset"".

MIPS64: Port "Reland of "MIPS: Optimize load/store with large offset"".

Port 961a45da69b613b819dbadf0c83b2b4ab820c68c

BUG=

Committed: https://crrev.com/daedefd3fc117754eaaa1b961880fff07d84852c
Cr-Commit-Position: refs/heads/master@{#41284}

[Marija Antic, 2016-11-18 13:51:19]

marija.antic@imgtec.com changed reviewers:
+ dusan.simicic@imgtec.com, ilija.pavlovic@imgtec.com,
ivica.bogosavljevic@imgtec.com, miran.karic@imgtec.com

[Marija Antic, 2016-11-18 13:51:20]

PTAL

[ivica.bogosavljevic, 2016-11-21 14:23:37]

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
File src/mips64/assembler-mips64.cc (right):

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1943: daddiu(at, zero_reg, (src.offset_ >>
kLuiShift) & kImm16Mask);
Do you know if there is a reason we are using 

daddiu(at, zero_reg, upperpart 16 bit part of offset)
dsll(at, at, kLuiShift)

instead of 
lui(...)?

Can we use lui instead?

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1954: DCHECK(!src.rm().is(at));
You should add a check here
DCHECK(is_int32(src.offset_));

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1970: int32_t
Assembler::LoadUpperOffsetForTwoMemoryAccesses(const MemOperand& src) {
If I am not mistaken, this is used by macro assembler sdc1 and ldc1 on MIPS32,
but not on MIPS64.

If it's not used anywhere, then it should be removed

[Marija Antic, 2016-11-24 08:46:29]

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
File src/mips64/assembler-mips64.cc (right):

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1943: daddiu(at, zero_reg, (src.offset_ >>
kLuiShift) & kImm16Mask);
I've ran a full test suite using lui, no problems here, so I will change this.
On 2016/11/21 14:23:36, ivica.bogosavljevic wrote:
> Do you know if there is a reason we are using 
> 
> daddiu(at, zero_reg, upperpart 16 bit part of offset)
> dsll(at, at, kLuiShift)
> 
> instead of 
> lui(...)?
> 
> Can we use lui instead?

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1954: DCHECK(!src.rm().is(at));
On 2016/11/21 14:23:36, ivica.bogosavljevic wrote:
> You should add a check here
> DCHECK(is_int32(src.offset_));

Done.

https://codereview.chromium.org/2505923002/diff/40001/src/mips64/assembler-mi...
src/mips64/assembler-mips64.cc:1970: int32_t
Assembler::LoadUpperOffsetForTwoMemoryAccesses(const MemOperand& src) {
On 2016/11/21 14:23:36, ivica.bogosavljevic wrote:
> If I am not mistaken, this is used by macro assembler sdc1 and ldc1 on MIPS32,
> but not on MIPS64.
> 
> If it's not used anywhere, then it should be removed

Done.

[ivica.bogosavljevic, 2016-11-25 08:41:00]

lgtm

[Marija Antic, 2016-11-25 08:43:32]

The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 08:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 09:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 09:08:41]

Dry run: This issue passed the CQ dry run.

[Marija Antic, 2016-11-25 09:09:36]

The CQ bit was checked by marija.antic@imgtec.com

[commit-bot: I haz the power, 2016-11-25 09:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 09:11:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480064976969640,
"parent_rev": "ddf46b6b21aa76c395c91fc3fd6e4f50c8013e3f", "commit_rev":
"be5d76a5c6d8bd9f96db2cd9ae03aa790fe84a2e"}

[commit-bot: I haz the power, 2016-11-25 09:12:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-25 09:12:36]

Description was changed from

==========
MIPS64: Port "Reland of "MIPS: Optimize load/store with large offset"".

Port 961a45da69b613b819dbadf0c83b2b4ab820c68c

BUG=
==========

to

==========
MIPS64: Port "Reland of "MIPS: Optimize load/store with large offset"".

Port 961a45da69b613b819dbadf0c83b2b4ab820c68c

BUG=

Committed: https://crrev.com/daedefd3fc117754eaaa1b961880fff07d84852c
Cr-Commit-Position: refs/heads/master@{#41284}
==========

[commit-bot: I haz the power, 2016-11-25 09:12:37]

Patchset 5 (id:??) landed as
https://crrev.com/daedefd3fc117754eaaa1b961880fff07d84852c
Cr-Commit-Position: refs/heads/master@{#41284}