Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2505853003: Refactor SharedFunctionInfo::IsBuiltin. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime-profiler.cc ('k') | src/runtime/runtime-internal.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug-evaluate.h" 8 #include "src/debug/debug-evaluate.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/debug-scopes.h" 10 #include "src/debug/debug-scopes.h"
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 // Add locals name and value from the temporary copy from the function frame. 771 // Add locals name and value from the temporary copy from the function frame.
772 for (const auto& local : locals) details->set(details_index++, *local); 772 for (const auto& local : locals) details->set(details_index++, *local);
773 773
774 // Add the value being returned. 774 // Add the value being returned.
775 if (at_return) { 775 if (at_return) {
776 details->set(details_index++, *return_value); 776 details->set(details_index++, *return_value);
777 } 777 }
778 778
779 // Add the receiver (same as in function frame). 779 // Add the receiver (same as in function frame).
780 Handle<Object> receiver(it.frame()->receiver(), isolate); 780 Handle<Object> receiver(it.frame()->receiver(), isolate);
781 DCHECK(!function->shared()->IsBuiltin()); 781 DCHECK(function->shared()->IsUserJavaScript());
782 DCHECK_IMPLIES(is_sloppy(shared->language_mode()), receiver->IsJSReceiver()); 782 DCHECK_IMPLIES(is_sloppy(shared->language_mode()), receiver->IsJSReceiver());
783 details->set(kFrameDetailsReceiverIndex, *receiver); 783 details->set(kFrameDetailsReceiverIndex, *receiver);
784 784
785 DCHECK_EQ(details_size, details_index); 785 DCHECK_EQ(details_size, details_index);
786 return *isolate->factory()->NewJSArrayWithElements(details); 786 return *isolate->factory()->NewJSArrayWithElements(details);
787 } 787 }
788 788
789 789
790 RUNTIME_FUNCTION(Runtime_GetScopeCount) { 790 RUNTIME_FUNCTION(Runtime_GetScopeCount) {
791 HandleScope scope(isolate); 791 HandleScope scope(isolate);
(...skipping 1112 matching lines...) Expand 10 before | Expand all | Expand 10 after
1904 } 1904 }
1905 1905
1906 1906
1907 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1907 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1908 UNIMPLEMENTED(); 1908 UNIMPLEMENTED();
1909 return NULL; 1909 return NULL;
1910 } 1910 }
1911 1911
1912 } // namespace internal 1912 } // namespace internal
1913 } // namespace v8 1913 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime-profiler.cc ('k') | src/runtime/runtime-internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698