Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 250583003: Remove RuntimeEnabledFeatures.h includes from a few headers (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
Reviewers:
adamk, ojan
CC:
blink-reviews, nessy, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), philipj_slow, gasubic, fs, eric.carlson_apple.com, dstockwell, dglazkov+blink, shans, Steve Block, adamk+blink_chromium.org, darktears, Eric Willigers, dino_apple.com, vcarbune.chromium, Timothy Loh, ojan
Visibility:
Public.

Description

Remove RuntimeEnabledFeatures.h includes from a few headers Changing RuntimeEnabledFeatures.in requires many files to be recompiled. Getting rid of these unnecessary includes didn't help much, but still... BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/html/HTMLDialogElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/animation/TimingFunction.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 8 months ago (2014-04-24 15:21:00 UTC) #1
adamk
lgtm
6 years, 8 months ago (2014-04-24 17:38:26 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 8 months ago (2014-04-24 18:17:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/250583003/1
6 years, 8 months ago (2014-04-24 18:17:54 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 18:24:34 UTC) #5
Message was sent while issue was closed.
Change committed as 172527

Powered by Google App Engine
This is Rietveld 408576698