Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 25058009: Unit tests for output protection in output configurator (Closed)

Created:
7 years, 2 months ago by kcwu
Modified:
7 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Unit tests for output protection in output configurator R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226414

Patch Set 1 #

Total comments: 13

Patch Set 2 : revise according to review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M chromeos/display/output_configurator_unittest.cc View 1 8 chunks +115 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kcwu
7 years, 2 months ago (2013-09-30 10:01:40 UTC) #1
Daniel Erat
Thanks for adding tests! This change basically looks fine to me; just a few comments. ...
7 years, 2 months ago (2013-09-30 14:01:16 UTC) #2
kcwu
https://codereview.chromium.org/25058009/diff/1/chromeos/display/output_configurator_unittest.cc File chromeos/display/output_configurator_unittest.cc (right): https://codereview.chromium.org/25058009/diff/1/chromeos/display/output_configurator_unittest.cc#newcode77 chromeos/display/output_configurator_unittest.cc:77: return base::StringPrintf("get_hdcp(id=%lu)", id); On 2013/09/30 14:01:16, Daniel Erat wrote: ...
7 years, 2 months ago (2013-10-01 07:15:51 UTC) #3
Daniel Erat
lgtm
7 years, 2 months ago (2013-10-01 12:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kcwu@chromium.org/25058009/6001
7 years, 2 months ago (2013-10-02 03:46:45 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 07:21:15 UTC) #6
Message was sent while issue was closed.
Change committed as 226414

Powered by Google App Engine
This is Rietveld 408576698