chromeos: Migrate SignOut and RequestRestartForUpdate to mojo interface

chromeos: Migrate SignOut and RequestRestartForUpdate to mojo interface

Under mustash the ash shell runs in a different process than chrome browser.
This migrates 2 methods from the in-process synchronous SystemTrayDelegate
to the mojo SystemTrayClient interface.

The implementations of these methods do a moderate amount of work inside
Chrome, so they did not seem like good candidates to try to implement inside
of ash itself. Ideally they methods would live in a user or login service,
but we don't have that yet either.

BUG=647412
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5
Cr-Commit-Position: refs/heads/master@{#432295}

[James Cook, 2016-11-15 22:43:00]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-11-15 22:43:17]

jamescook@chromium.org changed reviewers:
+ derat@chromium.org

[James Cook, 2016-11-15 22:43:18]

Dan, please take a look.

https://codereview.chromium.org/2505783002/diff/1/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2505783002/diff/1/ash/common/wm_shell.cc#newc...
ash/common/wm_shell.cc:358: // Accesses WmShell in its constructor.
I left this where it is because WmShell is probably going to go away, or be
folded into ash::Shell, in the next couple months. Initialization of the
LogoutConfirmationController could probably move into WmShell::Initialize() but
destruction looks like it needs to happen before all windows are closed, so I
would have to introduce a DeleteLogoutConfirmationController method.

[commit-bot: I haz the power, 2016-11-15 22:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-11-15 22:57:28]

lgtm

[James Cook, 2016-11-15 23:07:11]

jamescook@chromium.org changed reviewers:
+ tsepez@chromium.org

[James Cook, 2016-11-15 23:07:12]

tsepez, can I get security OWNERS for ash/public/interfaces/system_tray.mojom?

[commit-bot: I haz the power, 2016-11-15 23:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:11:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Tom Sepez, 2016-11-15 23:37:28]

OWNERS LGTM

[James Cook, 2016-11-15 23:38:27]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:39:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:55:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 00:01:29]

Description was changed from

==========
chromeos: Migrate SignOut and RequestRestartForUpdate to mojo interface

Under mustash the ash shell runs in a different process than chrome browser.
This migrates 2 methods from the in-process synchronous SystemTrayDelegate
to the mojo SystemTrayClient interface.

The implementations of these methods do a moderate amount of work inside
Chrome, so they did not seem like good candidates to try to implement inside
of ash itself. Ideally they methods would live in a user or login service,
but we don't have that yet either.

BUG=647412
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
chromeos: Migrate SignOut and RequestRestartForUpdate to mojo interface

Under mustash the ash shell runs in a different process than chrome browser.
This migrates 2 methods from the in-process synchronous SystemTrayDelegate
to the mojo SystemTrayClient interface.

The implementations of these methods do a moderate amount of work inside
Chrome, so they did not seem like good candidates to try to implement inside
of ash itself. Ideally they methods would live in a user or login service,
but we don't have that yet either.

BUG=647412
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5
Cr-Commit-Position: refs/heads/master@{#432295}
==========

[commit-bot: I haz the power, 2016-11-16 00:01:30]

Patchset 1 (id:??) landed as
https://crrev.com/1d43d5cad3f5a3533da527401200271a4f9524e5
Cr-Commit-Position: refs/heads/master@{#432295}