Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4839)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

Issue 2505753003: Revert of Fix three causes of blank thumbnails. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
index 1ebdc7017971e107984a4baa03cf9693c0171c14..55c233376bd7d9b0bd13cfc6ed9867edcaf4c582 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
@@ -10,6 +10,7 @@
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
+import org.chromium.chrome.browser.ntp.NativePageFactory;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
@@ -174,7 +175,11 @@
@Override
public void onPageLoadStarted(Tab tab, String url) {
String previousUrl = tab.getUrl();
- mTabContentManager.invalidateTabThumbnail(tab.getId(), previousUrl);
+ if (NativePageFactory.isNativePageUrl(previousUrl, tab.isIncognito())) {
+ mTabContentManager.invalidateTabThumbnail(tab.getId(), previousUrl);
+ } else {
+ mTabContentManager.removeTabThumbnail(tab.getId());
+ }
}
@Override
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698