integrate analysis options include directive into context builder

integrate analysis options include directive into context builder

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/abffe25b7d5bd894962f48b7a388e07a3e56e3bf

[danrubel, 2016-11-15 20:17:33]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[danrubel, 2016-11-15 20:24:11]

On 2016/11/15 20:17:33, danrubel wrote:

Integrated progress on https://github.com/dart-lang/sdk/issues/27817

[Brian Wilkerson, 2016-11-15 22:48:00]

lgtm

https://codereview.chromium.org/2505753002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2505753002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:341: List<UriResolver> resolvers =
<UriResolver>[
Perhaps add a TODO comment to restructure this so that we don't need to
re-compute the package map when we construct the source factory for the context
being built.

[danrubel, 2016-11-16 13:17:30]

https://codereview.chromium.org/2505753002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/builder.dart (right):

https://codereview.chromium.org/2505753002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/builder.dart:341: List<UriResolver> resolvers =
<UriResolver>[
On 2016/11/15 22:47:59, Brian Wilkerson wrote:
> Perhaps add a TODO comment to restructure this so that we don't need to
> re-compute the package map when we construct the source factory for the
context
> being built.

Done.

[danrubel, 2016-11-16 13:25:48]

Description was changed from

==========
integrate analysis options include directive into context builder
==========

to

==========
integrate analysis options include directive into context builder

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/abffe25b7d5bd894962f48b7a388e07a3e56e3bf
==========

[danrubel, 2016-11-16 13:25:49]

Committed patchset #2 (id:20001) manually as
abffe25b7d5bd894962f48b7a388e07a3e56e3bf (presubmit successful).