arc: enable use_new_wrapper_types for video_accelerator.mojom

arc: enable use_new_wrapper_types for video_accelerator.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/fd879031d441f0cf3927dac7762b20630d314c6b
Cr-Commit-Position: refs/heads/master@{#432961}

[Yusuke Sato, 2016-11-16 01:35:38]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 01:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-16 02:45:14]

yusukes@chromium.org changed reviewers:
+ lhchavez@chromium.org, posciak@chromium.org

[Yusuke Sato, 2016-11-16 02:45:14]

Owners, please take a look.

[Luis Héctor Chávez, 2016-11-16 03:04:57]

lgtm

https://codereview.chromium.org/2505733003/diff/1/chrome/gpu/gpu_arc_video_se...
File chrome/gpu/gpu_arc_video_service.cc (right):

https://codereview.chromium.org/2505733003/diff/1/chrome/gpu/gpu_arc_video_se...
chrome/gpu/gpu_arc_video_service.cc:267:
std::vector<ArcVideoAccelerator::DmabufPlane> converted_planes;
It's maybe better to create a typemapping for the DmabufPlane to avoid the
conversion altogether. Up to you to do it/delegate it to someone else or leave a
TODO+file a bug.

[commit-bot: I haz the power, 2016-11-16 03:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:37:39]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-16 06:17:16]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[Yusuke Sato, 2016-11-16 06:17:49]

Pawel: please take a look

https://codereview.chromium.org/2505733003/diff/1/chrome/gpu/gpu_arc_video_se...
File chrome/gpu/gpu_arc_video_service.cc (right):

https://codereview.chromium.org/2505733003/diff/1/chrome/gpu/gpu_arc_video_se...
chrome/gpu/gpu_arc_video_service.cc:267:
std::vector<ArcVideoAccelerator::DmabufPlane> converted_planes;
On 2016/11/16 03:04:57, Luis Héctor Chávez wrote:
> It's maybe better to create a typemapping for the DmabufPlane to avoid the
> conversion altogether. Up to you to do it/delegate it to someone else or leave
a
> TODO+file a bug.

Let me do it in a different CL. Added TODO and filed a bug.

[commit-bot: I haz the power, 2016-11-16 06:17:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 06:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 06:49:03]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Yusuke Sato, 2016-11-16 20:35:39]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 20:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 21:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:29:02]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Pawel Osciak, 2016-11-17 01:24:18]

lgtm % nit

https://codereview.chromium.org/2505733003/diff/40001/chrome/gpu/gpu_arc_vide...
File chrome/gpu/gpu_arc_video_service.cc (right):

https://codereview.chromium.org/2505733003/diff/40001/chrome/gpu/gpu_arc_vide...
chrome/gpu/gpu_arc_video_service.cc:273: converted_planes.emplace_back(0, 0);
Nit: it might actually be better to just report an error to client with
INVALID_ARGUMENT via OnError...

[Yusuke Sato, 2016-11-17 02:43:01]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[Yusuke Sato, 2016-11-17 02:43:17]

https://codereview.chromium.org/2505733003/diff/40001/chrome/gpu/gpu_arc_vide...
File chrome/gpu/gpu_arc_video_service.cc (right):

https://codereview.chromium.org/2505733003/diff/40001/chrome/gpu/gpu_arc_vide...
chrome/gpu/gpu_arc_video_service.cc:273: converted_planes.emplace_back(0, 0);
On 2016/11/17 01:24:18, Pawel Osciak wrote:
> Nit: it might actually be better to just report an error to client with
> INVALID_ARGUMENT via OnError...

Done.

[commit-bot: I haz the power, 2016-11-17 02:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Pawel Osciak, 2016-11-17 04:51:52]

thanks, still lgtm

[commit-bot: I haz the power, 2016-11-17 05:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 05:14:41]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-17 17:37:03]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-11-17 17:37:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2505733003/#ps60001
(title: "address comment from Pawel")

[commit-bot: I haz the power, 2016-11-17 17:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:45:32]

Failed to apply patch for components/arc/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: components/arc/BUILD.gn:131
  error: components/arc/BUILD.gn: patch does not apply

Patch:       components/arc/BUILD.gn
Index: components/arc/BUILD.gn
diff --git a/components/arc/BUILD.gn b/components/arc/BUILD.gn
index
2a28210490d2a3beb170ab079bc36b10bbbdfa4b..337ac57705342c6ae360ce3b54e9eb77b2fa4366
100644
--- a/components/arc/BUILD.gn
+++ b/components/arc/BUILD.gn
@@ -131,7 +131,6 @@ mojom("arc_bindings_old_types") {
     "common/bluetooth.mojom",
     "common/enterprise_reporting.mojom",
     "common/net.mojom",
-    "common/video_accelerator.mojom",
   ]
 
   public_deps = [
@@ -167,6 +166,7 @@ mojom("arc_bindings") {
     "common/storage_manager.mojom",
     "common/tts.mojom",
     "common/video.mojom",
+    "common/video_accelerator.mojom",
     "common/wallpaper.mojom",
   ]

[Yusuke Sato, 2016-11-17 17:46:58]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-11-17 17:46:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/2505733003/#ps80001
(title: "final rebase")

[commit-bot: I haz the power, 2016-11-17 17:48:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:27:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 21:32:46]

Description was changed from

==========
arc: enable use_new_wrapper_types for video_accelerator.mojom

BUG=662510
BUG=624136
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for video_accelerator.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/fd879031d441f0cf3927dac7762b20630d314c6b
Cr-Commit-Position: refs/heads/master@{#432961}
==========

[commit-bot: I haz the power, 2016-11-17 21:32:48]

Patchset 5 (id:??) landed as
https://crrev.com/fd879031d441f0cf3927dac7762b20630d314c6b
Cr-Commit-Position: refs/heads/master@{#432961}