Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 2505703002: Update error message in java_cpp_enum.py. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
mef, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, whywhat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update error message in java_cpp_enum.py. The new error message explains how to use brackets with multi-line directive declarations, which is useful since this feature isn't documented elsewhere. Also changed the default value of |_path| in |HeaderParser| since it was causing tests to raise exceptions because of a NoneType error. BUG=652018 Committed: https://crrev.com/9c44c94152587aea8b0d4a83f0df00398c2a5bee Cr-Commit-Position: refs/heads/master@{#432562}

Patch Set 1 #

Patch Set 2 : Fix formatting #

Patch Set 3 : Fix //net/base/request_priority.h empty prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M build/android/gyp/java_cpp_enum.py View 1 3 chunks +11 lines, -6 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 chunk +11 lines, -0 lines 0 comments Download
M net/base/request_priority.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
estevenson
ptal Andrew!
4 years, 1 month ago (2016-11-15 18:54:25 UTC) #3
agrieve
lgtm
4 years, 1 month ago (2016-11-15 19:27:35 UTC) #7
estevenson
mef@chromium.org: Please review changes in //net
4 years, 1 month ago (2016-11-15 22:54:44 UTC) #11
mef
net/ lgtm
4 years, 1 month ago (2016-11-16 17:50:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505703002/40001
4 years, 1 month ago (2016-11-16 18:16:44 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 18:25:24 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 18:52:34 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c44c94152587aea8b0d4a83f0df00398c2a5bee
Cr-Commit-Position: refs/heads/master@{#432562}

Powered by Google App Engine
This is Rietveld 408576698