Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2505693002: [scheduler] Initial budget for time-based throttling. (Closed)

Created:
4 years, 1 month ago by altimin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org, Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Initial budget for time-based throttling. Support adding extra budget in TimeBudgetPool API and use Finch settings to set up initial time budet level. R=alexclarke@chromium.org CC=skyostil@chromium.org BUG=639852 Committed: https://crrev.com/4428212a971d494640fad8aa86b3c5258d0fac03 Cr-Commit-Position: refs/heads/master@{#432614}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed SetTimeBudget to SetTimeBudgetRecoveryRate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -16 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc View 1 11 chunks +47 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc View 1 3 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
altimin
PTAL
4 years, 1 month ago (2016-11-15 18:42:47 UTC) #1
alex clarke (OOO till 29th)
https://codereview.chromium.org/2505693002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc (right): https://codereview.chromium.org/2505693002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc#newcode281 third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc:281: background_time_budget_pool_->SetTimeBudget(lazy_now.Now(), I think maybe we need to rename this ...
4 years, 1 month ago (2016-11-16 11:36:11 UTC) #2
altimin
PTAL https://codereview.chromium.org/2505693002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc File third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc (right): https://codereview.chromium.org/2505693002/diff/1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc#newcode281 third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc:281: background_time_budget_pool_->SetTimeBudget(lazy_now.Now(), On 2016/11/16 11:36:11, alex clarke wrote: > ...
4 years, 1 month ago (2016-11-16 11:59:56 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 1 month ago (2016-11-16 12:04:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505693002/20001
4 years, 1 month ago (2016-11-16 15:53:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/273611)
4 years, 1 month ago (2016-11-16 18:04:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505693002/20001
4 years, 1 month ago (2016-11-16 18:13:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 20:39:15 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 20:55:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4428212a971d494640fad8aa86b3c5258d0fac03
Cr-Commit-Position: refs/heads/master@{#432614}

Powered by Google App Engine
This is Rietveld 408576698